Skip to content

Conversation

@Pranay22077
Copy link
Contributor

Description:

Related issue(s):

Fixes #591

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Pranay22077 your workflows failed the unit tests

FAILED tests/unit/test_custom_fee.py::test_custom_fixed_fee - AssertionError: assert 'denominating_token_id=TokenId(shard_num=0, realm_num=0, num=123)' in 'CustomFixedFee(amount=100, denominating_token_id=TokenId(shard=0, realm=0, num=123, checksum=None), fee_collector_account_id=AccountId(shard=0, realm=0, num=456), all_collectors_are_exempt=True)'
========= 1 failed, 1206 passed, 300 deselected, 14 warnings in 3.76s ==========

You can run the unit tests locally before you push it and mark it as ready to review

@exploreriii
Copy link
Contributor

@Pranay22077 you have two outstanding issues to resolve before starting a new issue
Get in touch, discord.md if you need help please

@exploreriii
Copy link
Contributor

Hi @Pranay22077 I'll be releasing a new python sdk release soon -
if this PR is not done in time that's no problem, but note you will need to change your changelog entry and put it under a new unreleased section.
it may be easier to start fresh.
Thank you

@Pranay22077
Copy link
Contributor Author

Okay @exploreriii
Got it!

Thanks for informing!

@exploreriii
Copy link
Contributor

hi @Pranay22077 is this issue still active please? We have just released 0.1.8

@Pranay22077
Copy link
Contributor Author

Hey @exploreriii
Actually, I got very busy these days due to my exams, and this would take me some days more
If the issue needs to be resolved a little, I suggest to unassign me, and again make the issue open for others!

Thanks!

@exploreriii
Copy link
Contributor

Hi @Pranay22077 good luck with your exams
We can wait a while (but not weeks!), however, let me know if your status changes to request unassigned

@Pranay22077
Copy link
Contributor Author

Hey @exploreriii
Yes, it would take some time (till 7 December) for the exams to end.
and i feel, it's a good amount of time, so you can see accordingly what to be done
Thanks!

@exploreriii
Copy link
Contributor

Thanks for the information.
We will try to wait - but I will let you know if there is a dependency emerges and we need it faster - in which case I will re-assign. Meanwhile it continues assigned to you
Best wishes with your exams! Thanks again

@Pranay22077
Copy link
Contributor Author

Thanks a lot @exploreriii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add repr method to src/hiero_sdk_python/tokens/custom_fixed_fee.py

2 participants